Forum:Change the way we update Exchange pages

Forums: Yew Grove > Change the way we update Exchange pages

This page or section is an archive.
Please do not edit the contents of this page.
This thread was archived on 24 March 2010 by Tienjt0.

Currently, the prices in Exchange pages are stored and updated without commas (30000000 for 30M, 150000000 for 150M, etc.). These prices, especially for expensive items, are difficult to update and hard to distinguish. For example, 3000000 and 30000000 looks similar without the commas.

What I'm proposing is simple: we should start adding commas to Exchange prices when we update them. Template:, should fix issues with calculators and the Unrecognised punctuation character expression error. I have made the necessary changes to almost all of the Exchange templates, and do not foresee any issues when the commas are added.

Commas should be added to the following parameters: Price, Last, LowAlch, HighAlch, AbsMinPrice, AbsMaxPrice (and possibly Store).

Discussion

The operators of the Exchange-updating bots (User:SmackBot and User:AmauriceBot) have been notified, but so far nothing has been done. Please show your support so that we can pressure the bot operators to update their bots. I have a feeling that if I had the backing of the community, they might fix the bots to automatically add commas when the bots update. User:Azliq7 10:59, February 27, 2010 (UTC)

Support - Would make it a bit easier to combat vandalism Frede ^Talk 11:04, February 27, 2010 (UTC)

Support - per Azliq. It would reduce the number of inaccurate price updates (by users and IPs) as well. C.Chiam^Talk 11:04, February 27, 2010 (UTC)

Support - I can't see any downsides. _{Evil Yanks} ^talk 11:05, February 27, 2010 (UTC)

Support - Per Frede. Swiz ^Talk ^{Review Me} 11:17, February 27, 2010 (UTC)

Support - Per all. ~ Sentry Telos ^Talk 11:28, February 27, 2010 (UTC)

Support - If it doesn't screw up the calculations that these prices are used for, then why not. Oil4 ^Talk 12:10, February 27, 2010 (UTC)

Support - More Efficient. Ruud ^{(talk)(Suggest me naems)} 18:29, February 27, 2010 (UTC)

Support - Per all. --Quarenon _Talk 19:01, February 27, 2010 (UTC)

Support - Per all. bad_fetus^talk 20:40, February 27, 2010 (UTC)

Support - My eyes hurt when I see all the zeros. --Iiii I I I 20:42, February 27, 2010 (UTC)

Support - We don't want Iiii's 7 eyes to hurt :[ http://i698.photobucket.com/albums/vv341/Rwojy/scoot4.pngscoot ies 20:47, February 27, 2010 (UTC)

Support - Give them some time. They are busy and might not have seen the messages yet. --Liquid^Talk 23:01, February 27, 2010 (UTC)

S,u,p,p,o,r,t - commas ftw Tollerach hates SoF 09:43, February 28, 2010 (UTC)

Support - do it. --Aburnett ^(Talk) 20:49, February 28, 2010 (UTC)

Also, we should adjust [[Template:GEPriceUpdateGuide]] to reflect the use of commas (change (without commas and without "k"/"m"; i.e. "42000", not "42,000" or "42k"). to (without "k"/"m"; i.e. "42,000" not "42k").. --Aburnett ^(Talk) 20:54, February 28, 2010 (UTC)

Done. --Quarenon _Talk 21:32, February 28, 2010 (UTC)

Oh, I thought we would wait till the bots were updated, I had heard some talk of the bots having issues with commas in prices. I'm assuming that isn't the case =] --Aburnett ^(Talk) 22:06, February 28, 2010 (UTC)

Added a nowiki tag to GEPriceUpdateGuide. We are now using {{GEMWHelp}} instead. See Forum:Reforming GEMW instruction templates. User:Lil diriz 77/Signatures 04:28, May 7, 2010 (UTC)

Support - Sounds good to me. Panjy16 ★ 21:02, February 28, 2010 (UTC)

Support - While we're at it, why not add functionality into the template that understands k and m, just in case? I'm a regular user and I approve this message. TLUL ^{Talk - Contribs} 22:43, February 28, 2010 (UTC)

Nice idea! It can be done using REPLACE as in Template:,. But I'm fairly certain the bots will have to updated/rewritten... recognising "k" and "m" is an entirely different story. User:Azliq7 09:09, March 1, 2010 (UTC)

Yeah, the bots would probably choke up on it unless there was some serious rewriting (even the commas would have that effect). But, we could slowly phase in support just for those cases where somebody writes it that way. I'm not entirely sure that a simple replace would work. Removing commas, expr multiplying, and re-adding commas would be the way to do it. Picture the following example, where k is replaced with three zeroes.

1250k -> 245000, with commas becomes 245, 000 - Correct
1.25m -> 1.25000000 - Incorrect

It's a possibility. I may see if I can improve TLULbot's code for it, after I'm done coding the current task. After all, having a bot recognize another way of writing the data can only be a benefit. I'm a regular user and I approve this message. TLUL ^{Talk - Contribs} 01:11, March 2, 2010 (UTC)

SB if I remember correctly, rewrites all prices taking out commas, decimal points, k's and m's. I will hack in a change to commarify all relevant numbers after it has done everything else. There is, however, downside. The downside is ironically overhead. We are using template {{,}} to remove commas, then #formatnum: to put them back in. There is on Wikipedia a maximum number of of template calls on a page, not sure if that's implemented on Wikia. I do know some pages take a while to render. Rich Farmbrough, 09:25 8 March 2010 (GMT).

Done, all (or almost all) Exchange pages updated or updating now. Rich Farmbrough, 12:51 8 March 2010 (GMT).

Thanks. Could you add commas to the other parameters as well (see above)?User:Azliq7 09:47, March 9, 2010 (UTC)

Conditional Support Maybe spaces, more worldwide accepted as thousands separators than commas. Some countries use dots... 4ndrepd ^Talk_Contribs^{Jump to the God Wars II!} 22:45, March 15, 2010 (UTC)

More countries use commas than spaces. 300 000 000 isn't as clear as 300,000,000. Most people are smart enough to know that something that says "Price: 1,245gp" doesn't cost 1 gp and 245 cents, but 1245 gp.

Oil4 ^Talk 16:01, March 16, 2010 (UTC)

Support- sounds good. Sentra246 09:25, March 21, 2010 (UTC)

Requesting closure - This has been already been implemented, right? --Aburnett ^(Talk) 18:42, March 21, 2010 (UTC)

Yes. User:Azliq7 04:04, March 23, 2010 (UTC)

Closed - Proposal has been implemented. Ti en 21:49, March 24, 2010 (UTC)